Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show bookmark bar on NTP by default #3251

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 24, 2019

Fix brave/brave-browser#5781

Submitter Checklist:

Test Plan:

yarn test brave_browser_tests --filter=*BookmarkBarOnNTPTest*

  1. Launch browser with clean profile
  2. Check Always show bookmarks bar on New Tab page is on by default

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 0.71.x - Nightly milestone Aug 24, 2019
@simonhong simonhong self-assigned this Aug 24, 2019
@simonhong simonhong requested a review from emerick August 26, 2019 13:17
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit 7738615 into master Aug 27, 2019
@simonhong
Copy link
Member Author

@bsclifton @rebron I'll create uplift PR after below three uplift PRs are merged.
#3243
#3244
#3250

@conscienta
Copy link

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bookmarks bar visible on New Tabs Page by default
3 participants